Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for unittests, matrix_is_tester tests, black and flake8 #346

Merged
merged 14 commits into from
May 28, 2021

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented May 27, 2021

This PR adds the unit tests, matrix_is_tester tests, towncrier checks, black code formatting checks and flake8 lint checks to github actions. Note that since the flake8 linting is failing (it runs but the code doesn't pass) and the unit tests and matrix_is_tests are run only after the codestyle checks pass, they are not running-I added those first and verified that they run before adding anything else.

signed off by H.Shay, shaysquared@gmail.com

@H-Shay H-Shay changed the title Add GitHub actions for unittests, matrx_is_tester tests, black and flake8 Add GitHub actions for unittests, matrix_is_tester tests, black and flake8 May 27, 2021
@callahad callahad self-assigned this May 27, 2021
@callahad callahad self-requested a review May 27, 2021 21:09
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Added a few comments

setup.py Outdated Show resolved Hide resolved
changelog.d/346.misc Outdated Show resolved Hide resolved
.github/workflows/pipeline.yml Outdated Show resolved Hide resolved
.github/workflows/pipeline.yml Outdated Show resolved Hide resolved
@H-Shay
Copy link
Contributor Author

H-Shay commented May 27, 2021

Awesome I will make these changes tomorrow morning.

@callahad
Copy link
Contributor

Looks good, let's see if it works 😉

@callahad callahad merged commit 7eb4b14 into matrix-org:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants