-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions for unittests, matrix_is_tester tests, black and flake8 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
changed the title
Add GitHub actions for unittests, matrx_is_tester tests, black and flake8
Add GitHub actions for unittests, matrix_is_tester tests, black and flake8
May 27, 2021
callahad
suggested changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added a few comments
callahad
reviewed
May 27, 2021
callahad
reviewed
May 27, 2021
Awesome I will make these changes tomorrow morning. |
Looks good, let's see if it works 😉 |
callahad
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the unit tests, matrix_is_tester tests, towncrier checks, black code formatting checks and flake8 lint checks to github actions. Note that since the flake8 linting is failing (it runs but the code doesn't pass) and the unit tests and matrix_is_tests are run only after the codestyle checks pass, they are not running-I added those first and verified that they run before adding anything else.
signed off by H.Shay, shaysquared@gmail.com